-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol versioning support #1209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qookei
force-pushed
the
symbol-versioning
branch
from
December 27, 2024 04:34
0c525e9
to
d15047f
Compare
Without this, the compiler can (and will) hoist the inline assembly in potentially broken ways.
qookei
force-pushed
the
symbol-versioning
branch
from
December 27, 2024 18:49
d15047f
to
e055f72
Compare
Geertiebear
reviewed
Dec 27, 2024
64
reviewed
Dec 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
qookei
force-pushed
the
symbol-versioning
branch
from
December 29, 2024 22:38
9f7742f
to
0a8bcda
Compare
64
approved these changes
Dec 30, 2024
Dennisbonke
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All resolution functions now optionally take the version of the symbol to resolve to. Specifying no version means the default is picked (for dlsym etc).
Some compiler optimizations done via builtins can cause the tests to fail (e.g. compiler optimizes out failing call to calloc, and assumes that it succeeds).
qookei
force-pushed
the
symbol-versioning
branch
from
December 31, 2024 05:05
0a8bcda
to
41173bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some minor TODOs left in the code (handling weak versions and figuring out what to do about VERDEF dependency names), but this is sufficient to fix #1208, and the TODOs aren't a problem when booting Managarm (which has plenty of libraries with versioned symbols).
Closes #1208.