Implement various syscalls on Linux for systemd #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Dennisbonke
force-pushed
the
lfs-systemd-sysdeps
branch
from
3e0bdce to
640ca23
Compare
|
As mentioned on Discord, the clone patch is not ready for inclusion -- clone() needs to integrate with the pthreads code, otherwise things will break horribly with |
avdgrinten
reviewed
Jan 11, 2025
Comment on lines
+239
to
+240
| [[gnu::weak]] int sys_name_to_handle_at(int dirfd, const char *pathname, struct file_handle *handle, int *mount_id, int flags); | ||
| [[gnu::weak]] int sys_splice(int in_fd, off_t *in_off, int out_fd, off_t *out_off, size_t size, unsigned int flags, size_t *out); |
There was a problem hiding this comment.
These are Linux extensions, not POSIX. Do we still keep them in this header?
| @@ -83,6 +84,12 @@ int sys_ioctl(int fd, unsigned long request, void *arg, int *result); | |||
|
|
|||
| [[gnu::weak]] int sys_getifaddrs(struct ifaddrs **); | |||
|
|
|||
| [[gnu::weak]] int sys_sendfile(int outfd, int infd, off_t *offset, size_t count, size_t *out); | |||
There was a problem hiding this comment.
sendfile() returns ssize_t, not size_t. However, the value is always positive, so passing size_t * is probably okay. I'm not sure how we handle this for other syscalls, but if it's consistent with other calls, it can stay like this.
The same applies to sys_splice().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.