Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options/posix: Fix function prototype of pthread_exit #933

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Dennisbonke
Copy link
Member

It's currently returning an int, and spec says it should be noreturn void. Draft as I'm not quite sure if this is now correct.

options/posix/generic/pthread-stubs.cpp Outdated Show resolved Hide resolved
@Dennisbonke Dennisbonke marked this pull request as ready for review January 4, 2024 15:24
Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit 6184a59 into managarm:master Jan 24, 2024
29 of 30 checks passed
@Dennisbonke Dennisbonke deleted the noreturn branch January 24, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants