base: Add separate bootstrap-cargo-home for rustc bootstrapping #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64
reviewed
Mar 31, 2024
xbstrap/__init__.py
Outdated
| @@ -97,6 +97,35 @@ def do_init(args): | |||
| os.symlink(os.path.join(args.src_root, "bootstrap.yml"), "bootstrap.link") | |||
|
|
|||
| cfg = config_for_args(args) | |||
| if cfg.bootstrap_cargo_config_toml is not None: | |||
There was a problem hiding this comment.
It would be better to make a function rather than copy the code below
|
Closing as discussed on Discord. We don't need this workaround right now, as we can just set $CARGO_HOME to a path in the build directory instead. In the future, if necessary, this could be picked up to provide multiple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to correctly build
host-rustcin bootstrap-managarm with upstream tooling.