Fix crash when a YulPath contains multiple YulIdentifier

This happens when there is special member access in some Yul identifier (like `x.slot` or `x.offset`). I think this issue was introduced when unreserving the `address` keyword since that changed the structure of `YulPath`. There is a proper test case in NomicFoundation#1149 already, but without this fix running Sanctuary with existing rules crashes.
manastech · Nov 25, 2024 · d8419e2 · d8419e2
1 parent fe89f8d
commit d8419e2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/crates/solidity/inputs/language/bindings/rules.msgb b/crates/solidity/inputs/language/bindings/rules.msgb
@@ -2265,9 +2265,11 @@ inherit .lexical_scope
   edge @path.lexical_scope -> @expr.lexical_scope
 }
 
-@path [YulPath @name [YulIdentifier]] {
+@path [YulPath] {
   node @path.lexical_scope
+}
 
+@path [YulPath @name [YulIdentifier]] {
   node ref
   attr (ref) node_reference = @name
 

diff --git a/crates/solidity/outputs/cargo/crate/src/generated/bindings/generated/binding_rules.rs b/crates/solidity/outputs/cargo/crate/src/generated/bindings/generated/binding_rules.rs