Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the valid return codes at googlechrome.vm #1146

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Support the valid return codes at googlechrome.vm #1146

merged 1 commit into from
Oct 2, 2024

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Oct 2, 2024

Closes #1138.

@d35ha d35ha self-assigned this Oct 2, 2024
@d35ha d35ha added 🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Oct 2, 2024
@d35ha d35ha mentioned this pull request Oct 2, 2024
Merged
Ana06
Ana06 reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use the VM-Install-With-Installer helper? It would make the code simpler, consistent ans easier to maintain. 🤔

@d35ha
Copy link
Member Author

d35ha commented Oct 2, 2024 •
edited
Loading

Is it possible to use the VM-Install-With-Installer helper? It would make the code simpler, consistent ans easier to maintain. 🤔

@Ana06
Using VM-Install-With-Installer would require a SHA256 hash, therefore a versioned URL. The used MSI URL is not versioned.

@Ana06
Copy link
Member

Ana06 commented Oct 2, 2024 •
edited
Loading

@d35ha

Using VM-Install-With-Installer would require a SHA256 hash, therefore a versioned URL. The used MSI URL is not versioned.

You are right, how could I forget this? 🙈

Ana06
Ana06 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @d35ha!

@Ana06 Ana06 merged commit 8547c45 into mandiant:main Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ana06 Ana06 Ana06 approved these changes

Assignees

@d35ha d35ha

Labels
🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

googlechrome.vm fails when Github action image updates to latest chrome
2 participants
@d35ha @Ana06