Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify packages with names d to e #1278

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

sara-rn
Copy link
Contributor

@sara-rn sara-rn commented Feb 13, 2025

Second PR that modifies packages with names d to e
Adds the category to the nuspec file
Script to update packages https://gist.github.com/sara-rn/9b5d66e5b016e0eb36477ac180d50433
Removed dcode as it fails
Closes #1107

@sara-rn sara-rn self-assigned this Feb 13, 2025
@sara-rn sara-rn force-pushed the add-packages-tags-d-e branch 4 times, most recently from 3d1af20 to 9a0ad18 Compare February 18, 2025 09:40
@sara-rn
Copy link
Contributor Author

sara-rn commented Feb 18, 2025

It fails due to the dcode package, the URL returns 404, however I checked the URL and it seems to work

@Ana06
Copy link
Member

Ana06 commented Feb 18, 2025

@sara-rn dcode is failing in our daily run too: https://github.com/mandiant/VM-Packages/wiki/Daily-Failures I recommend to remove the change in dcode from this PR so that we can merge the other packages and send a PR only for dcode. You will have the same issue for the other packages failing in the daily (dcode.vm, ida.plugin.sigmaker.vm, netcat.vm, and regcool.vm). We need to fix all the failing packages, as we need them to work in the CI to modify them and we need to modify them to move the category to the nuspec. I think some of them are easy to fix (likely just updating a hash).

I am not sure what the issue with dcode is, you may need to do some debugging like testing the package locally and downloading it with CURL. It could be the URL has issues some times (similar to the issue with 010Editor: #1275). In that case, we would need to document the testing we have done in an issue and reach Digital Detective Group Ltd to see if they are able to help (as we did in #1275).

@Ana06
Copy link
Member

Ana06 commented Feb 18, 2025

INFO: @sara-rn has implemented these changes using the script https://gist.github.com/sara-rn/9b5d66e5b016e0eb36477ac180d50433 We are splitting the moving of the category to the nuspec in several PRs to avoid issues with the CI (as recommended in the Continuous Integration (CI) Testing Wiki page).

@sara-rn sara-rn force-pushed the add-packages-tags-d-e branch 4 times, most recently from e223425 to 5151d13 Compare February 18, 2025 11:36
Add category to the nuspec package and retrieve the category in the install
script from the nuspec
@sara-rn sara-rn force-pushed the add-packages-tags-d-e branch from 5151d13 to cfe6239 Compare February 18, 2025 11:38
@Ana06 Ana06 merged commit 1c5d665 into mandiant:main Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the categories to the nuspec & Add wiki page with tools by categories
2 participants