Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to Serilog 4.0 #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrades to Serilog 4.0 #72

wants to merge 3 commits into from

Conversation

StasPerekrestov
Copy link
Contributor

Dear Mani,

Please review this pull request.

Summary:

  1. Upgrades Serilog to 4.0
  2. Adds .NET 8.0 and removes .NET 5.0 from Target Frameworks
  3. Adds source-generated Regex support for .NET 8.0 + to LogFormatter
  4. Uses introduced in Serilog 3.1 properties TraceId/SpanId to propagate trace context

Please let me know if you see that the PR could be improved.

Thank you.

Stanislav Perekrestov added 3 commits June 3, 2024 11:45
fixes incorrect variable reference
1fadaf1
Adds .NET 8.0 support and upgrades to Serilog 4.0 (manigandham#71)
b5735b8
propagates current trace and span ids (manigandham#67)
a6608ab 
Serilog starting from v3.1.0 adds two new first-class properties to LogEvent: TraceId and SpanId. These are set automatically in Logger.Write() to the corresponding property values from System.Diagnostics.Activity.Current.
@StasPerekrestov StasPerekrestov mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StasPerekrestov