Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spain Flag #25

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Spain Flag #25

wants to merge 7 commits into from

Conversation

josevill
Copy link
Contributor

It's valid to use this one without the coat of arms.

@manrajgrover
Copy link
Owner

@josevill Hey! 😄

This looks great! I'm not sure if it is valid though. If you can share some related source, it would be great!

Also, please update the README.md file as per Contributions guidelines.

@josevill
Copy link
Contributor Author

@manrajgrover Hi there. Here's some related info about the flag. https://en.wikipedia.org/wiki/Flag_of_Spain
I will update the readme file in a bit..

@josevill
Copy link
Contributor Author

@manrajgrover Done :)

Flags/Spain.html Outdated
#spain {
width: 150px;
height: 92px;
background: linear-gradient(180deg, #d03e3e 0%, #d03e3e 25%, #ffc100 25%, #ffc100 75%, #d03e3e 75%, #d03e3e 100%); }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: There is an extra closing bracket here. Please fix it.

@manrajgrover
Copy link
Owner

@josevill Awesome. I have left 1 small nit. Please fix it. Also, please resolve merge conflicts, so that we can merge it. 😊

@manrajgrover
Copy link
Owner

@josevill Please resolve merge conflicts too. :)

@josevill
Copy link
Contributor Author

I think i have to do this from the computer. I'm new to this kind of stuff haha

@manrajgrover
Copy link
Owner

@josevill No rushes. Great opportunity to learn. :D

@josevill
Copy link
Contributor Author

@manrajgrover After uhhh almost 3 years, this is now updated :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants