Canadian flag support for IE and Edge #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the unfortunate side effect of introducing a Firefox-specific hack because of a few issues with the renderer. On the bright side, both IE and Edge are now supported, and a crisper leaf is displayed for Webkit-based renderers.
|
@ScottKaye This is great but I would have to find an alternative to test it before merging. If you can share some screenshots, it would help too. |
|
Should look identical to the existing one, but I can take some screen shots if that would help. |
|
@ScottKaye Will give me more confidence. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi reddit!
This PR is a fix for the Canadian flag in IE and Edge. It has the unfortunate side effect of introducing a Firefox-specific hack because of a few issues with its renderer, however, both IE and Edge are now supported with a crisper leaf displaying on Webkit.
Something like this would never be used in production, this is just a collection of hacks to get a nice-looking Canadian flag to appear in Firefox, Chrome, IE 10+, and Edge. Other browsers might work too, but I didn't test beyond those four.