-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved: Favicon missing on subpage Pages and bugs in README file #1055
Resolved: Favicon missing on subpage Pages and bugs in README file #1055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly! Feel free to join our community on Discord to discuss more! |
🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out. |
issue no?? |
It is present in the description of the PR. I have followed the given template |
Thanks for reviewing the PR. Hope you have a great day ahead :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reducing levels to 1 @rajdeepchakraborty-rc
- empty spaces
- code formatting
- added comments
- few minor changes.
@mansiruhil13 if you're on discord or LinkedIn kindly DM me or any other Program Manager
(dont worry you seem beginner as a PA, i can see you never review the code, so just want to clarify some guidlines and proper labelling of points)
@MastanSayyad Ok. I trust your judgment. I want to express my sincere apologies for any missteps on my end, should there have been any. |
Description
Missing Favicon on Subpages:
Added the missing Favicons to the Home and Nearby pages and also to the new Feedback page(recently added).
Readme Program Banners Updation:
I have updated the banners to fit better in the README file. I have updated the GSSoC banner to GSSoC Extended Program banner and also adjusted the orientation of the Hacktoberfest Banner(a banner is usually landscape and should be more on length that on breadth)
Readme file Team section:
Due to changing your profile picture again the Team Section was broken. I have fixed and adjusted the Team section back to the normal size:
Screenshots (if applicable)
Missing Favicon on Subpages:
Before:
It is missing in the Home page and the Nearby page:
After:
Home:
Nearby:
Feedback:
Readme Program Banners Updation:
Before:
After:
Readme file Team section:
Type of Change
Checklist
Additional Information
Please review the PR and assign it to me with the necessary labels.