Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved: Favicon missing on subpage Pages and bugs in README file #1055

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

rajdeepchakraborty-rc
Copy link
Contributor

Description

Missing Favicon on Subpages:

Added the missing Favicons to the Home and Nearby pages and also to the new Feedback page(recently added).

Readme Program Banners Updation:

I have updated the banners to fit better in the README file. I have updated the GSSoC banner to GSSoC Extended Program banner and also adjusted the orientation of the Hacktoberfest Banner(a banner is usually landscape and should be more on length that on breadth)

Readme file Team section:

Due to changing your profile picture again the Team Section was broken. I have fixed and adjusted the Team section back to the normal size:

Screenshots (if applicable)

Missing Favicon on Subpages:

  • Before:
    It is missing in the Home page and the Nearby page:
    image

  • After:
    Home:
    image
    Nearby:
    image
    Feedback:
    image

Readme Program Banners Updation:

  • Before:
    image

  • After:
    image

Readme file Team section:

  • Before:

image

  • After:

image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the contributing document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added necessary tests to ensure my changes are effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information


Please review the PR and assign it to me with the necessary labels.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 2:51pm

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

@mansiruhil13
Copy link
Owner

issue no??

@rajdeepchakraborty-rc
Copy link
Contributor Author

issue no??

It is present in the description of the PR. I have followed the given template

@rajdeepchakraborty-rc
Copy link
Contributor Author

Thanks for reviewing the PR. Hope you have a great day ahead :)

@rajdeepchakraborty-rc rajdeepchakraborty-rc deleted the favicon branch October 24, 2024 17:40
Copy link
Collaborator

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing levels to 1 @rajdeepchakraborty-rc

  • empty spaces
  • code formatting
  • added comments
  • few minor changes.

@mansiruhil13 if you're on discord or LinkedIn kindly DM me or any other Program Manager

(dont worry you seem beginner as a PA, i can see you never review the code, so just want to clarify some guidlines and proper labelling of points)

@rajdeepchakraborty-rc
Copy link
Contributor Author

@MastanSayyad Ok. I trust your judgment. I want to express my sincere apologies for any missteps on my end, should there have been any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Favicon missing in Home and Nearby Page
3 participants