[ANSIENG-3149] | Add precheck for Kraft Controller port availability (c…

…onfluentinc#1540)

* [ANSIENG-2966] | Add precheck for Kraft Controller port availability

* [ANSIENG-2966] | Update uri module to get Jolokia json output

playbooks/ZKtoKraftMigration.yml

@@ -22,24 +22,26 @@
       uri:
         url: "{{ 'https' if kafka_controller_jolokia_ssl_enabled|bool else 'http' }}://localhost:{{kafka_controller_jolokia_port}}/jolokia/read/kafka.controller:type=KafkaController,name=ZkMigrationState"
         validate_certs: false
+        return_content: true
         status_code: 200
       retries: "{{ metadata_migration_retries }}"
       delay: 90
-      until: jolokia_output.json.value.Value == 1
+      until: ( jolokia_output.content | from_json ).value.Value == 1
       register: jolokia_output
       when: jolokia_auth_mode == "none"
 
     - name: Wait for Metadata Migration when Basic Jolokia auth
       uri:
         url: "{{ 'https' if kafka_controller_jolokia_ssl_enabled|bool else 'http' }}://localhost:{{kafka_controller_jolokia_port}}/jolokia/read/kafka.controller:type=KafkaController,name=ZkMigrationState"
         validate_certs: false
+        return_content: true
         force_basic_auth: true
         url_username: "{{ jolokia_user }}"
         url_password: "{{ jolokia_password }}"
         status_code: 200
       retries: "{{ metadata_migration_retries }}"
       delay: 90
-      until: jolokia_output.json.value.Value == 1
+      until: ( jolokia_output.content | from_json ).value.Value == 1
       register: jolokia_output
       when: jolokia_auth_mode == "basic"
 
@@ -138,24 +140,26 @@
       uri:
         url: "{{ 'https' if kafka_controller_jolokia_ssl_enabled|bool else 'http' }}://localhost:{{kafka_controller_jolokia_port}}/jolokia/read/kafka.controller:type=KafkaController,name=ZkMigrationState"
         validate_certs: false
+        return_content: true
         status_code: 200
       retries: "{{ metadata_migration_retries }}"
       delay: 90
-      until: jolokia_output.json.value.Value == 3
+      until: ( jolokia_output.content | from_json ).value.Value == 3
       register: jolokia_output
       when: jolokia_auth_mode == "none"
 
     - name: Validate Cluster is in Kraft mode when Basic Jolokia auth
       uri:
         url: "{{ 'https' if kafka_controller_jolokia_ssl_enabled|bool else 'http' }}://localhost:{{kafka_controller_jolokia_port}}/jolokia/read/kafka.controller:type=KafkaController,name=ZkMigrationState"
         validate_certs: false
+        return_content: true
         force_basic_auth: true
         url_username: "{{ jolokia_user }}"
         url_password: "{{ jolokia_password }}"
         status_code: 200
       retries: "{{ metadata_migration_retries }}"
       delay: 90
-      until: jolokia_output.json.value.Value == 3
+      until: ( jolokia_output.content | from_json ).value.Value == 3
       register: jolokia_output
       when: jolokia_auth_mode == "basic"
 

playbooks/migration_precheck.yml

@@ -3,6 +3,9 @@
   hosts: localhost
   gather_facts: false
   tasks:
+    - import_role:
+        name: variables
+
     - name: Check the presence of Controller in the inventory file
       fail:
         msg:  "Please add Kraft Controller hosts in the inventory file for migration."
@@ -21,6 +24,18 @@
       when:
         - not (kraft_migration | default(false) | bool)
 
+    - name: Get List of Kafka Broker listeners' ports
+      set_fact:
+        kafka_broker_ports: "{% for listener in kafka_broker_listeners|dict2items %}{% if loop.index > 1%},{% endif %}{{ listener['value']['port'] }}{% endfor %}"
+
+    - name: Check Kraft port in colocated Migration
+      fail:
+        msg: "Port {{kafka_controller_port}} is already occupied for {{item}}, Please use a different port for Kraft Controller."
+      when:
+        - item in groups.kafka_broker
+        - kafka_controller_port|string in kafka_broker_ports.split(',')
+      loop: "{{ groups.kafka_controller }}"
+
 - name: Check Current Confluent Version
   hosts: zookeeper,kafka_broker
   gather_facts: false