Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

36863 find global b matrix warnings #38574

Merged
merged 28 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
f3b15ca
Added a parent function to call child algs
andy-bridger Jan 7, 2025
b92824f
replaced child_IndexPeaks
andy-bridger Jan 7, 2025
f257439
replaced getUBMatrix
andy-bridger Jan 7, 2025
500d15b
replaced calculateUMatrix
andy-bridger Jan 7, 2025
1d8cd52
replaced transformHKL
andy-bridger Jan 7, 2025
0c8760b
replaced copySample
andy-bridger Jan 7, 2025
8e7d8b7
added error catching for CalcUMatrix
andy-bridger Jan 7, 2025
edfc14c
fixed IndexPeaks: only return npeaks
andy-bridger Jan 7, 2025
fe9fae7
Updated find_initial_indexing loop
andy-bridger Jan 7, 2025
5d2094b
updated the find_initial_indexing
andy-bridger Jan 7, 2025
576d0ca
fixed optimisation bug
andy-bridger Jan 8, 2025
00ab5ab
relax MIN_NUM_INDEXED_PEAKS to 2
andy-bridger Jan 8, 2025
ee16d28
updated input validation and improved err msg
andy-bridger Jan 8, 2025
76e254a
updated warning logging after refinement
andy-bridger Jan 8, 2025
020af37
updated test coverage
andy-bridger Jan 8, 2025
870856d
added release note
andy-bridger Jan 8, 2025
820aecc
updated validateInputs and its tests
andy-bridger Jan 15, 2025
76d314b
reduced num repeated loops and calcs
andy-bridger Jan 15, 2025
e5a7d5a
removed redundant IndexPeaks call
andy-bridger Jan 15, 2025
c790f57
moved SetUB call to exec_child_alg
andy-bridger Jan 15, 2025
c98ff40
made final treatment of refUB into one loop
andy-bridger Jan 15, 2025
a516873
collapse removal warning into one message
andy-bridger Jan 15, 2025
80a7c63
improved readability of find_initial_indexing
andy-bridger Jan 15, 2025
7a9e55c
added check and test for num_ws indexed by ref_ub
andy-bridger Jan 15, 2025
5f4ec8c
added check and test for make_ub_consistent
andy-bridger Jan 15, 2025
413294e
replace in-place popping with new list appending
andy-bridger Jan 16, 2025
ceda6fc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 16, 2025
23abc08
amend clarity of warnings when too few peaks
andy-bridger Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading