handle optional query params with defaults

manualpilot · Oct 6, 2024 · 8b3dcde · 8b3dcde
1 parent 09fbf89
commit 8b3dcde
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/generator/fixes.mjs b/generator/fixes.mjs
@@ -20,12 +20,21 @@ export function applyFixes(schema) {
 
       // if an input type has a default value on the docker backend
       // then we want the option to omit it completely
-      if (
-        schema.definitions[definition].properties[property].default ||
-        schema.definitions[definition].properties[property].default === false
-      ) {
+      if (schema.definitions[definition].properties[property].hasOwnProperty("default")) {
         schema.definitions[definition].properties[property].default = undefined;
       }
     }
   }
+
+  for (const path in schema.paths) {
+    for (const endpoint in schema.paths[path]) {
+      if (schema.paths[path][endpoint].parameters) {
+        for (const param of schema.paths[path][endpoint].parameters) {
+          if (param.hasOwnProperty("default")) {
+            param.default = undefined;
+          }
+        }
+      }
+    }
+  }
 }
diff --git a/tests/basic.test.ts b/tests/basic.test.ts
@@ -8,7 +8,6 @@ test("DockerClient", async () => {
   // TODO: this returns transfer-encoding chunked
   await client.Image.Create({
     query: {
-      platform: "",  // TODO: fix defaults in query params
       fromImage: "hello-world",
       tag: "latest",
     },