Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix very minor Makefile issue in spidermonkey clean target (#109) #110

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

mzpqnxow
Copy link
Contributor

@mzpqnxow mzpqnxow commented Sep 5, 2021

This fixes #109 and while I didn't test it across different platforms, I did confirm there is no breakage with the build or clean targets on a Linux system with a glibc+gcc toolchain

If you don't think this is really necessary please feel free to close it

Thanks!

@mzpqnxow
Copy link
Contributor Author

@manugarg any interest in merging this? Or maybe you committed a fix yourself already? I'm just testing out the GitHub mobile app, apologies if you already fixed this, I vaguely remember you commenting on this but I don't see it here

@manugarg manugarg merged commit bc15d3b into manugarg:master Mar 23, 2022
@manugarg
Copy link
Owner

Thanks for this. Sorry for the super long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spidermonkey makefile causes error in the clean target
2 participants