Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bearings in field of view handling #615

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Use bearings in field of view handling #615

merged 3 commits into from
Apr 2, 2024

Conversation

oscarlorentzon
Copy link
Member

Motivation

Ensure that cameras with a >180 degree field of view are handled correctly.

Contribution

  • Use bearings to determine field of view for render camera.
  • Use bearings to determine field of view for pan images.
  • Apply zoom to max field of view calculation.

Test Plan

yarn build
yarn test
yarn start

localhost:8000/tag.html
localhost:8000/fisheye.html

@oscarlorentzon
feat: apply zoom to max zoom
bf4262f 
Ensure that zooming works for wide angled fisheyes.
Apply zoom to max value.
@oscarlorentzon
feat: use bearing in render camera
4d96110 
Use bearings instead if basic coordinates to handle cases
where fov is >180 deg.
@oscarlorentzon
feat: use bearings in pan service
fa8730f 
Support combined panning for fisheyes with horizontal
fov >180 degrees.
@oscarlorentzon oscarlorentzon added this to the v5.0.0 milestone Apr 2, 2024
@oscarlorentzon oscarlorentzon self-assigned this Apr 2, 2024
@oscarlorentzon oscarlorentzon merged commit 9d1b72a into main Apr 2, 2024
5 checks passed
@oscarlorentzon oscarlorentzon deleted the feature-render-fov branch April 2, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oscarlorentzon oscarlorentzon

Labels
cla signed
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarlorentzon @facebook-github-bot