Skip to content

Commit

Permalink
Few a few URLs and typos (#4221)
Browse files Browse the repository at this point in the history
  • Loading branch information
coliff authored Jun 4, 2024
1 parent 9e2f2c4 commit 0945152
Show file tree
Hide file tree
Showing 14 changed files with 17 additions and 16 deletions.
1 change: 1 addition & 0 deletions ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ _Note that a particular bucket may appear multiple times in `tile.buckets`--once
- Binding layout buffer data (via `BufferGroup`) and calling `gl.drawElements()`

Compiling and caching GL shader programs is managed by the `Painter` and `ProgramConfiguration` classes. In particular, an instance of `ProgramConfiguration` handles, for a given (tile, style layer) pair:

- Expanding a `#pragma mapbox` statement in our shader source into either a _uniform_ or _attribute_, _varying_, and _local_ variable declaration, depending on whether or not the relevant style property is data-driven.
- Creating and populating a _paint_ vertex array for data-driven properties, corresponding to the `attributes` declared in the shader. (This happens at layout time, on the worker side.)

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- _...Add new stuff here..._

### 🐞 Bug fixes

- ⚠️ Allow breaking lines in labels before a left parenthesis ([#4138](https://github.com/maplibre/maplibre-gl-js/pull/4138))
- ⚠️ Fix ignoring embedded line breaks when `symbol-placement` is `line` or `line-center` ([#4124](https://github.com/maplibre/maplibre-gl-js/pull/4124))
- _...Add new stuff here..._
Expand Down Expand Up @@ -2056,7 +2057,7 @@ August 16, 2018
- Use setData operation when diffing geojson sources [#5332](https://github.com/mapbox/mapbox-gl-js/pull/5332)
- Return early from draw calls on layers where opacity=0 [#5429](https://github.com/mapbox/mapbox-gl-js/pull/5429)
- A [heatmap](https://www.mapbox.com/mapbox-gl-js/example/heatmap-layer/) layer type is now available. This layer type allows you to visualize and explore massive datasets of points, reflecting the shape and density of data well while also looking beautiful. See [the blog post](https://blog.mapbox.com/sneak-peek-at-heatmaps-in-mapbox-gl-73b41d4b16ae) for further details.
![](https://cdn-images-1.medium.com/max/1600/1*Dme5MAgdA3pYdTRHUQzvLw.png)
![heatmap screenshot](https://cdn-images-1.medium.com/max/1600/1*Dme5MAgdA3pYdTRHUQzvLw.png)
- The value of a style property or filter can now be an [expression](https://www.mapbox.com/mapbox-gl-js/style-spec/#expressions). Expressions are a way of doing data-driven and zoom-driven styling that provides more flexibility and control, and unifies property and filter syntax.

Previously, data-driven and zoom-driven styling relied on stop functions: you specify a feature property and a set of input-output pairs that essentially define a “scale” for how the style should be calculated based on the feature property. For example, the following would set circle colors on a green-to-red scale based on the value of `feature.properties.population`:
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Examples are written as regular html files in `test/examples`. Each example shou
When you create a new example, you **must** make an accompanying image.

1. Run `npm run generate-images <example-file-name>`. The script will take a screenshot of the map in the example and save it to `docs/assets/examples/`.
2. Optimize the image with [Squoosh](https://squoosh.app/) to reduce the file size. (Optiomal)
2. Optimize the image with [Squoosh](https://squoosh.app/) to reduce the file size. (Optional)
3. Commit the image.

For some examples, `npm run generate-images` does not generate an ideal image. In these cases, you can interact with the map after running the command before the screenshot is taken, or take a screenshot yourself by running the site locally with `npm start`, take a screenshot and save it in the `docs/assets/examples/` folder.
Expand Down
2 changes: 1 addition & 1 deletion src/source/tile_cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type {Tile} from './tile';

/**
* @internal
* A [least-recently-used cache](http://en.wikipedia.org/wiki/Cache_algorithms)
* A [least-recently-used cache](https://en.wikipedia.org/wiki/Cache_algorithms)
* with hash lookup made possible by keeping a list of keys in parallel to
* an array of dictionary of values
*/
Expand Down
2 changes: 1 addition & 1 deletion src/ui/handler/scroll_zoom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export class ScrollZoomHandler implements Handler {
this._type = null;
this._lastValue = value;

// Start a timeout in case this was a singular event, and dely it by up to 40ms.
// Start a timeout in case this was a singular event, and delay it by up to 40ms.
this._timeout = setTimeout(this._onTimeout, 40, e);

} else if (!this._type) {
Expand Down
2 changes: 1 addition & 1 deletion src/util/actor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export interface IActor {
export type MessageHandler<T extends MessageType> = (mapId: string | number, params: RequestResponseMessageMap[T][0], abortController?: AbortController) => Promise<RequestResponseMessageMap[T][1]>

/**
* An implementation of the [Actor design pattern](http://en.wikipedia.org/wiki/Actor_model)
* An implementation of the [Actor design pattern](https://en.wikipedia.org/wiki/Actor_model)
* that maintains the relationship between asynchronous tasks and the objects
* that spin them off - in this case, tasks like parsing parts of styles,
* owned by the styles
Expand Down
2 changes: 1 addition & 1 deletion src/util/ajax.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ describe('ajax', () => {

test('should preserve user-specified Accept header', async () => {
server.respondWith(request => {
// Note that postgrest responds to this type of request with application/geo+json
// Note that PostgREST responds to this type of request with application/geo+json
request.respond(200, {'Content-Type': 'application/geo+json'}, '{"foo": "bar"}');
});

Expand Down
2 changes: 1 addition & 1 deletion src/util/find_pole_of_inaccessibility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {distToSegmentSquared} from './intersection_tests';

/**
* Finds an approximation of a polygon's Pole Of Inaccessibility https://en.wikipedia.org/wiki/Pole_of_inaccessibility
* This is a copy of http://github.com/mapbox/polylabel adapted to use Points
* This is a copy of https://github.com/mapbox/polylabel adapted to use Points
*
* @param polygonRings - first item in array is the outer ring followed optionally by the list of holes, should be an element of the result of util/classify_rings
* @param precision - Specified in input coordinate units. If 0 returns after first run, if `> 0` repeatedly narrows the search space until the radius of the area searched for the best pole is less than precision
Expand Down
2 changes: 1 addition & 1 deletion src/util/geolocation_support.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export async function checkGeolocationSupport(forceRecalculation = false): Promi
return supportsGeolocation;
}
// navigator.permissions has incomplete browser support
// http://caniuse.com/#feat=permissions-api
// https://caniuse.com/#feat=permissions-api
// Test for the case where a browser disables Geolocation because of an
// insecure origin
try {
Expand Down
2 changes: 1 addition & 1 deletion src/util/intersection_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function pointIntersectsBufferedLine(p: Point, line: Line, radius: number) {
return false;
}

// Code from http://stackoverflow.com/a/1501725/331379.
// Code from https://stackoverflow.com/a/1501725/331379.
function distToSegmentSquared(p: Point, v: Point, w: Point) {
const l2 = v.distSqr(w);
if (l2 === 0) return p.distSqr(v);
Expand Down
4 changes: 2 additions & 2 deletions src/util/is_char_in_unicode_block.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// The following table comes from <http://www.unicode.org/Public/12.0.0/ucd/Blocks.txt>.
// Keep it synchronized with <http://www.unicode.org/Public/UCD/latest/ucd/Blocks.txt>.
// The following table comes from <https://www.unicode.org/Public/12.0.0/ucd/Blocks.txt>.
// Keep it synchronized with <https://www.unicode.org/Public/UCD/latest/ucd/Blocks.txt>.

type UnicodeBlockLookup = {[key: string]: (char: number) => boolean};

Expand Down
6 changes: 3 additions & 3 deletions src/util/script_detection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ export function charAllowsIdeographicBreaking(char: number) {
}

// The following logic comes from
// <http://www.unicode.org/Public/12.0.0/ucd/VerticalOrientation.txt>.
// <https://www.unicode.org/Public/12.0.0/ucd/VerticalOrientation.txt>.
// Keep it synchronized with
// <http://www.unicode.org/Public/UCD/latest/ucd/VerticalOrientation.txt>.
// <https://www.unicode.org/Public/UCD/latest/ucd/VerticalOrientation.txt>.
// The data file denotes with “U” or “Tu” any codepoint that may be drawn
// upright in vertical text but does not distinguish between upright and
// “neutral” characters.
Expand Down Expand Up @@ -297,7 +297,7 @@ export function charInSupportedScript(char: number, canRenderRTL: boolean) {
isChar['Khmer'](char)) {
// These blocks cover common scripts that require
// complex text shaping, based on unicode script metadata:
// http://www.unicode.org/repos/cldr/trunk/common/properties/scriptMetadata.txt
// https://www.unicode.org/repos/cldr/trunk/common/properties/scriptMetadata.txt
// where "Web Rank <= 32" "Shaping Required = YES"
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/util/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export function warnOnce(message: string): void {
*
* @returns true for a counter clockwise set of points
*/
// http://bryceboe.com/2006/10/23/line-segment-intersection-algorithm/
// https://bryceboe.com/2006/10/23/line-segment-intersection-algorithm/
export function isCounterClockwise(a: Point, b: Point, c: Point): boolean {
return (c.y - a.y) * (b.x - a.x) > (b.y - a.y) * (c.x - a.x);
}
Expand Down
1 change: 0 additions & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ You may also run tests and view output with the plugin [orta.vscode-jest](https:

If you do so, note that the initial test run may take a while (3 minutes or so), during which time the test results are not yet available.


## Integration Tests

See [`test/integration/README.md`](./integration/README.md).
Expand Down

0 comments on commit 0945152

Please sign in to comment.