Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use as a cmake included project #100

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

nunojpg
Copy link
Contributor

@nunojpg nunojpg commented Jan 13, 2024

With this change I can add this project with "add_subdirectory" and just use it with just QMapLibre::Widgets in the target_link_libraries.

I am only using QT Widgets with set(MLN_QT_WITH_LOCATION OFF), so my patch probably does not fix QML builds.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64bf8c4) 45.29% compared to head (efab633) 45.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files          35       35           
  Lines        2126     2126           
=======================================
  Hits          963      963           
  Misses       1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ntadej ntadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

In principle I am fine with the changes, but probably we can clean the include paths a bit more. I can also do it later if you want.

src/core/CMakeLists.txt Show resolved Hide resolved
@ntadej ntadej merged commit cbc7cbe into maplibre:main Jan 14, 2024
31 checks passed
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants