New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MapLibre QML module namespace independent of QtLocation #130

Merged

ntadej merged 3 commits into maplibre:main from ntadej:qml-module-name

May 5, 2024

Collaborator

ntadej commented May 5, 2024

Make MapLibre QML module namespace independent of QtLocation to prevent potential deployment issues. The syntax now changes from import QtLocation.MapLibre 3.0 to just import MapLibre 3.0.

ntadej requested a review from louwers

May 5, 2024 16:34

louwers reviewed

View reviewed changes

test/qml/qt5/tst_map.qml Outdated Show resolved Hide resolved

louwers approved these changes

View reviewed changes

Collaborator

louwers left a comment

LGTM after the copyright comment is resolved.


          Make MapLibre QML module namespace independent of QtLocation

c95ccaf

ntadej force-pushed the qml-module-name branch from 8c7a587 to c95ccaf Compare

May 5, 2024 17:56

louwers reviewed

View reviewed changes

examples/quick/main.qml Outdated Show resolved Hide resolved

louwers reviewed

View reviewed changes

test/qml/qt6/tst_style_parameters.qml Outdated Show resolved Hide resolved

louwers reviewed

View reviewed changes

test/qml/qt6/tst_map.qml Outdated Show resolved Hide resolved

louwers reviewed

View reviewed changes

test/qml/qt5/tst_style_parameters.qml Outdated Show resolved Hide resolved

louwers reviewed

View reviewed changes

test/qml/qt5/tst_map.qml Outdated Show resolved Hide resolved

louwers reviewed

View reviewed changes

src/location/plugins/legacy/qml_module.cpp Outdated Show resolved Hide resolved

louwers reviewed

View reviewed changes

src/location/plugins/legacy/qml_registration.cpp Outdated Show resolved Hide resolved


          Revert copyright year change

194419e

louwers approved these changes

View reviewed changes

fix

839e060

ntadej force-pushed the qml-module-name branch from 11fb9cd to 839e060 Compare

May 5, 2024 20:00

ntadej merged commit 01c8ca5 into maplibre:main

33 checks passed

ntadej deleted the qml-module-name branch

May 5, 2024 20:33

ntadej added this to the 3.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet