Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename setFramebufferObject -> setOpenGLFramebufferObject #161

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Rename setFramebufferObject -> setOpenGLFramebufferObject #161

merged 1 commit into from
Aug 27, 2024

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Aug 27, 2024

Probably makes sense to rename OpenGL-specific (at least I think it will be) setFramebufferObject to setOpenGLFramebufferObject.

In preparation for stable 3.0 release.

HarelM
HarelM approved these changes Aug 27, 2024
View reviewed changes
Copy link

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this will be released only in a breaking change version.

@ntadej
Copy link
Collaborator Author

ntadej commented Aug 27, 2024

Yes, 3.0 (stable is now 2.x).

@ntadej ntadej merged commit 48b2e07 into maplibre:main Aug 27, 2024
42 checks passed
@ntadej ntadej deleted the gl-rename branch August 27, 2024 18:49
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees

@ntadej ntadej

@HarelM HarelM

@birkskyum birkskyum

Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ntadej @HarelM @birkskyum