Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve umbrella header generation #64

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Nov 15, 2023

Improve umbrella header generation so they are not re-created on each CMake run.

@ntadej ntadej requested review from louwers and birkskyum November 15, 2023 00:01
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b0db29) 36.20% compared to head (cfd35ca) 36.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   36.20%   36.20%           
=======================================
  Files          25       25           
  Lines        1820     1820           
=======================================
  Hits          659      659           
  Misses       1161     1161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the umbrella header in this context?

@ntadej
Copy link
Collaborator Author

ntadej commented Nov 21, 2023

Qt has it common that for one library you import everything at once. So we have QMapLibre header which just includes all other public headers. Here we try to make the library behave similar to Qt so users can use it in the same fashion.

For now the header is not fully generated yet, but this is a first step towards it.

@ntadej ntadej merged commit 75366ce into maplibre:main Nov 21, 2023
@ntadej ntadej deleted the umbrella branch November 21, 2023 14:16
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants