Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #91

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Windows support #91

merged 6 commits into from
Jan 5, 2024

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Jan 2, 2024

  • StyleChange needs explicit constructors due to MSVC handling them differently (for usage in std::unique_ptr)
  • minor cmake tweaks for multi-config
  • tests will only run on CMake 3.22 and later as PATH needs to be set
  • examples use native Qt CMake deployment macros
  • QtSql is disabled by default on Windows (in separate PR I will probably disable it by default for all platforms)

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85673cb) 45.27% compared to head (63e3a67) 45.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   45.27%   45.27%           
=======================================
  Files          35       35           
  Lines        2125     2125           
=======================================
  Hits          962      962           
  Misses       1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntadej ntadej force-pushed the win branch 4 times, most recently from b41820a to eff3d12 Compare January 4, 2024 18:51
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about Windows (and very little about Qt), so I cannot really do a proper review, but it looks legit!

@ntadej
Copy link
Collaborator Author

ntadej commented Jan 5, 2024

Thanks!

The goal is to cut a (pre)release of 3.0 soon so users can start properly testing. The initial feedback was promising so I do not expect major issues (besides some API changes motivating 2.X -> 3.X bump).

@ntadej ntadej merged commit 9a8d36a into maplibre:main Jan 5, 2024
31 checks passed
@ntadej ntadej deleted the win branch January 5, 2024 11:44
@ntadej ntadej modified the milestones: 3.1, 3.0 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants