-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #91
Windows support #91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 45.27% 45.27%
=======================================
Files 35 35
Lines 2125 2125
=======================================
Hits 962 962
Misses 1163 1163 ☔ View full report in Codecov by Sentry. |
b41820a
to
eff3d12
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know nothing about Windows (and very little about Qt), so I cannot really do a proper review, but it looks legit!
Thanks! The goal is to cut a (pre)release of 3.0 soon so users can start properly testing. The initial feedback was promising so I do not expect major issues (besides some API changes motivating 2.X -> 3.X bump). |
StyleChange
needs explicit constructors due to MSVC handling them differently (for usage instd::unique_ptr
)PATH
needs to be set