Skip to content
Back to pull request #88

Add reminder to add changelog entry to pull request template #215

Sign in to view logs

Add reminder to add changelog entry to pull request template

Add reminder to add changelog entry to pull request template #215

Triggered via pull request August 21, 2024 22:46
@michaelkirkmichaelkirk
synchronize #88
michaelkirk:mkirk/changelog-reminder
Status Success
Total duration 12m 28s
Artifacts –

ios.yml

on: pull_request
Code Style
11s
Code Style
Build and Test
12m 17s
Build and Test
Fit to window
Zoom out
Zoom in

Annotations

35 warnings
Code Style: MapboxNavigation/CarPlayManager.swift#L572
FIXMEs should be resolved (Unable to tilt map during rout...) (todo)
Code Style: MapboxNavigation/InstructionPresenter.swift#L239
FIXMEs should be resolved (Can we work with the image dir...) (todo)
Code Style: MapboxNavigation/NavigationMapView.swift#L754
TODOs should be resolved (Change to point-based distance...) (todo)
Code Style: MapboxNavigation/CarPlayNavigationViewController.swift#L271
TODOs should be resolved (handle lanes.) (todo)
Code Style: MapboxNavigation/CarPlayNavigationViewController.swift#L298
TODOs should be resolved (no such method exists, and the...) (todo)
Code Style: MapboxCoreNavigation/NavigationSettings.swift#L79
Prefer the new block based KVO API with keypaths when using Swift 3.2 or later (block_based_kvo)
Code Style: MapboxCoreNavigation/RouteProgress.swift#L26
TODOs should be resolved (Set stepIndex to 0 or last ind...) (todo)
Code Style: MapboxCoreNavigation/DistanceFormatter.swift#L136
Computed properties should first declare the getter and then the setter (computed_accessors_order)
Code Style: MapboxCoreNavigation/DistanceFormatter.swift#L112
`where` clauses are preferred over a single `if` inside a `for` (for_where)
Code Style: MapboxCoreNavigation/RouteController.swift#L674
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSDictionary+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSArray+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNConversion.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingIndicator.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingArrowLayer.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Metal.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSComparisonPredicate+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Impl.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSValue+MLNStyleAttributeAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'UIView+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSDictionary+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSArray+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNConversion.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingIndicator.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingArrowLayer.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Metal.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSComparisonPredicate+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Impl.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSValue+MLNStyleAttributeAdditions.h' [-Wincomplete-umbrella]
Build and Test: Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphoneos/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'UIView+MLNAdditions.h' [-Wincomplete-umbrella]
Build and Test: MapboxNavigation/RouteMapViewController.swift#L137
'automaticallyAdjustsScrollViewInsets' was deprecated in iOS 11.0: Use UIScrollView's contentInsetAdjustmentBehavior instead
Build and Test: MapboxNavigation/NavigationViewController.swift#L773
'UILocalNotification' was deprecated in iOS 10.0: Use UserNotifications Framework's UNNotificationRequest
Build and Test: MapboxNavigation/NavigationViewController.swift#L779
'cancelAllLocalNotifications()' was deprecated in iOS 10.0: Use UserNotifications Framework's -[UNUserNotificationCenter removeAllPendingNotificationRequests]
Build and Test: MapboxNavigation/NavigationViewController.swift#L780
'scheduleLocalNotification' was deprecated in iOS 10.0: Use UserNotifications Framework's -[UNUserNotificationCenter addNotificationRequest:withCompletionHandler:]
Build and Test
xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify