SwiftUI Optimisation

Example/example/SceneDelegate.swift

@@ -94,7 +94,7 @@ private extension SceneDelegate {
             let simulatedLocationManager = SimulatedLocationManager(route: route)
             simulatedLocationManager.speedMultiplier = 2
 
-            self.viewController.startNavigation(with: route, locationManager: simulatedLocationManager)
+            self.viewController.startNavigation(with: route, animated: true, locationManager: simulatedLocationManager)
         }
     }
 

MapboxNavigation/NavigationViewController.swift

@@ -214,6 +214,8 @@
 
     var currentStatusBarStyle: UIStatusBarStyle = .default {
         didSet {
+            guard oldValue != self.currentStatusBarStyle else { return }
+
             self.mapViewController.instructionsBannerView.backgroundColor = InstructionsBannerView.appearance().backgroundColor
             self.mapViewController.instructionsBannerContentView.backgroundColor = InstructionsBannerContentView.appearance().backgroundColor
         }
@@ -228,6 +230,8 @@
      */
     public var route: Route? {
         didSet {
+            guard oldValue != self.route else { return }
+
             if let route {
                 if self.routeController == nil {
                     let routeController = RouteController(along: route, directions: self.directions, locationManager: self.locationManager)
@@ -283,6 +287,8 @@
      */
     public var routeController: RouteController? {
         didSet {
+            guard oldValue != self.routeController else { return }
+
             self.mapViewController.routeController = self.routeController
         }
     }
@@ -313,6 +319,8 @@
      */
     public var automaticallyAdjustsStyleForTimeOfDay = true {
         didSet {
+            guard oldValue != self.automaticallyAdjustsStyleForTimeOfDay else { return }
+
             self.styleManager.automaticallyAdjustsStyleForTimeOfDay = self.automaticallyAdjustsStyleForTimeOfDay
         }
     }
@@ -427,10 +435,8 @@
 
     // MARK: - NavigationViewController
 
-    public func startNavigation(with route: Route, animated: Bool, routeController: RouteController? = nil, locationManager: NavigationLocationManager? = nil) {
-        if let locationManager {
-            self.locationManager = locationManager
-        }
+    public func startNavigation(with route: Route, animated: Bool, routeController: RouteController? = nil, locationManager: NavigationLocationManager = NavigationLocationManager()) {
+        self.locationManager = locationManager
         if let routeController {
             self.routeController = routeController
         }
@@ -467,6 +473,7 @@
 
         self.voiceController = nil
         self.route = nil
+        self.locationManager = NavigationLocationManager()
 
         self.mapViewController.navigationView.hideUI(animated: animated)
         self.mapView.tracksUserCourse = false
@@ -649,7 +656,9 @@
                 guard let self else {
                     return
                 }
-                self.delegate?.navigationViewControllerDidFinishRouting?(self)
+                self.mapViewController.hideEndOfRoute { _ in
+                    self.delegate?.navigationViewControllerDidFinishRouting?(self)
+                }
             })
         }
         return advancesToNextLeg
@@ -752,14 +761,14 @@
         guard UIApplication.shared.applicationState == .background else { return }
         guard let text = step.instructionsSpokenAlongStep?.last?.text else { return }
 
         let notification = UILocalNotification()
         notification.alertBody = text
         notification.fireDate = Date()
 
         self.clearStaleNotifications()
 
         UIApplication.shared.cancelAllLocalNotifications()
         UIApplication.shared.scheduleLocalNotification(notification)
     }
 
     func clearStaleNotifications() {