Sprite docs: format list of file types correctly, and document that pixelRatio is required #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of the two file types (index file and image file) was formatted as a list with three items. The second item should be a paragraph within the first item. The paragraph following that also needs to include `pixelRatio` in the list of required properties.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 78.02% 78.02%
=======================================
Files 101 101
Lines 4142 4142
Branches 1184 1184
=======================================
Hits 3232 3232
Misses 910 910 ☔ View full report in Codecov by Sentry. |
HarelM
approved these changes
Oct 6, 2023
|
THANKS!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #355 and #356, here are another couple of issues I've noticed on the sprite documentation page.
The list of the two file types (index file and image file) was formatted as a list with three items. The second item should be a paragraph within the first item.
The paragraph following that also needs to include
pixelRatioin the list of required properties (there are five required properties, not four).Launch Checklist