Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add centerAltitude to style spec #875

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

NathanMOlson
Copy link
Contributor

Launch Checklist

Add centerAltitude to style spec, as discussed here: #851

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (30d9ad4) to head (835d69a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #875   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files         105      105           
  Lines        4681     4683    +2     
  Branches     1322     1323    +1     
=======================================
+ Hits         4341     4343    +2     
  Misses        340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NathanMOlson NathanMOlson marked this pull request as draft October 29, 2024 17:08
@HarelM HarelM requested review from louwers and ibesora October 29, 2024 20:52
@HarelM
Copy link
Collaborator

HarelM commented Oct 29, 2024

LGTM.
@ibesora @louwers please approve as well.

@NathanMOlson NathanMOlson marked this pull request as ready for review October 29, 2024 21:06
src/reference/v8.json Outdated Show resolved Hide resolved
@HarelM HarelM enabled auto-merge (squash) October 31, 2024 13:28
@HarelM HarelM merged commit 3ab2cdb into maplibre:main Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants