Use modern jsonlint fork

[birkskyum]

We have a few vulnerabilities mentioned when installing, due to obsolete versions of Underscore, which comes from a 10y old version of jsonlint.

This PR swap the old jsonlint from 2015:
https://github.com/josdejong/jsonlint

With this one:
https://github.com/prantlf/jsonlint

Launch Checklist

• Briefly describe the changes in this PR.
• Link to related issues.
• Include before/after visuals or gifs if this PR includes visual changes.
• Write tests for all new functionality.
• Add an entry to CHANGELOG.md under the ## main section.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.48%. Comparing base (af01346) to head (36a1d4c).
Report is 46 commits behind head on main.

Files with missing lines	Patch %	Lines
src/libs/codemirror-mgl.ts	78.26%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   59.84%   63.48%   +3.63%     
==========================================
  Files         104      104              
  Lines        3011     5773    +2762     
  Branches      680     1727    +1047     
==========================================
+ Hits         1802     3665    +1863     
- Misses       1209     2107     +898     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HarelM]

This looks good assuming it is working as expected, were there other mentioning of this package that can be removed? Maybe in the rollup configuration?
Can this be done to the style-spec package as well?

[birkskyum]

@HarelM I got the error reporting working.

It's now using the error from the catch(err) now instead of the parseError hack

For instance setting below, where there is inserted an m before the color code:

{
  "id": "background",
  "type": "background",
  "paint": {
    "background-color": m"#D8F2FF"
  },
  "filter": ["all"],
  "layout": {"visibility": "visible"},
  "maxzoom": 24
}

Before

After

[birkskyum]

I abstracted this error handling out. It's the exact same function we had twice for some reason

[HarelM]

Is it possible to add a test to cover this scenario?
Otherwise looks great, thanks!

[birkskyum]

@HarelM , I managed to add a test that break the json syntax, and checks that the red error circle appear in the side of the editor

It passes on both main and this PR.

[HarelM]

Thanks!

[HarelM]

Just remove the "only" and you can merge it, thanks!!