-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insertion of access tokens, when swapping renderer #1021
base: main
Are you sure you want to change the base?
Fix insertion of access tokens, when swapping renderer #1021
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 59.84% 64.37% +4.53%
==========================================
Files 104 104
Lines 3011 5825 +2814
Branches 680 1749 +1069
==========================================
+ Hits 1802 3750 +1948
- Misses 1209 2073 +864
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
Is there a test we can add to make sure this behavior is kept in the future? |
f9b4025
to
ffce5cf
Compare
ffce5cf
to
c612220
Compare
I'm not sure how to test this through dom/cypress. It's quite different from the other tests, as it's about network calls and visual output on canvas. Cypress clearly is capable of both (network and snapshots), I just have to study it. |
You can use Cypress to intercept network calls I believe. |
@HarelM , figured out the test now. It checks the requests made after the render change has the access token instead of just |
Going from e.g. MapTiler to OpenLayers and back will lose the maptlier key.
This code finds the urls in the style that has "{key}" and insert the correct API keys
Fixes the error reported here, cc @nyurik
Related to:
Launch Checklist
CHANGELOG.md
under the## main
section.