-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add code coverage #852
add code coverage #852
Conversation
Please add output file to fit ignore (out.json). |
Can you grant me permissions to your repo? |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9e0794:
|
I have fixed the package lock but it seems that the coverage is causing the test to fail for some reason. |
THANKS BTW! |
Is this still an issue? it seems we just need to add baseUrl |
Yes, this is still an issue, you can see it in the Firefox CI run. |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS!
Add Cypress code coverage using Istanbul nyc