-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve drivers #856
improve drivers #856
Conversation
@HarelM , can you please push a lockfile? Even when creating a lockfile with codespaces the build fails |
My codespaces account is maxed out for this month... :-/
Did you try that? |
@HarelM , |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6650262:
|
I did the above with the addition of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
==========================================
- Coverage 57.18% 57.15% -0.04%
==========================================
Files 104 104
Lines 2929 2929
Branches 674 674
==========================================
- Hits 1675 1674 -1
- Misses 1254 1255 +1 ☔ View full report in Codecov by Sentry. |
Layes tests were a bit hard to review, I hope it's similar as I was not able to fully compare one test to the other. |
I really need to find a way to fix this lint rule for the switch case... :-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approved, THANKS!
I have reviewed and made sure the tests in layers.cy.ts
are the same.
I have left a few minor comments.
No description provided.