Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a version warning for Postgis<3.5 #1681

Merged

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Feb 6, 2025

could not go to sleep, so PR instead.. insomnia is a bitch ^^

This adds a version warning for postgis<3.5

Yes, it might be a bit too early too tell, but all signs point to older versions being buggy.
Lets keep #1651 open to keep tabs on weather the upstream issue changes.

@CommanderStorm CommanderStorm enabled auto-merge (squash) February 6, 2025 04:04
@CommanderStorm CommanderStorm requested a review from nyurik February 6, 2025 04:04
@sharkAndshark
Copy link
Collaborator

sharkAndshark commented Feb 6, 2025

Seems new warning needs to be removed either in test.sh

martin/tests/test.sh

Lines 186 to 189 in e024ff0

# Older versions of PostGIS don't support the margin parameter, so we need to remove it from the log
remove_line "$LOG_FILE" 'Margin parameter in ST_TileEnvelope is not supported'
remove_line "$LOG_FILE" 'Source IDs must be unique'
remove_line "$LOG_FILE" 'PostgreSQL 11.10.0 is older than the recommended 12.0.0'

@CommanderStorm CommanderStorm requested a review from nyurik February 6, 2025 12:35
@CommanderStorm
Copy link
Collaborator Author

What a messy PR.. Sorry about this.. Next time no PRs at 3:30AM..

@sharkAndshark
Copy link
Collaborator

I got insomnia either last night.. loll

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@CommanderStorm CommanderStorm merged commit e628c39 into maplibre:main Feb 7, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants