-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a version warning for Postgis<3.5 #1681
Merged
CommanderStorm
merged 12 commits into
maplibre:main
from
CommanderStorm:add-a-postgis-version-warning
Feb 7, 2025
Merged
add a version warning for Postgis<3.5 #1681
CommanderStorm
merged 12 commits into
maplibre:main
from
CommanderStorm:add-a-postgis-version-warning
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
reviewed
Feb 6, 2025
nyurik
reviewed
Feb 6, 2025
Co-authored-by: Yuri Astrakhan <[email protected]>
nyurik
reviewed
Feb 6, 2025
nyurik
reviewed
Feb 6, 2025
nyurik
reviewed
Feb 6, 2025
nyurik
reviewed
Feb 6, 2025
nyurik
reviewed
Feb 6, 2025
Seems new warning needs to be removed either in Lines 186 to 189 in e024ff0
|
Co-authored-by: Yuri Astrakhan <[email protected]>
Co-authored-by: Yuri Astrakhan <[email protected]>
Co-authored-by: Yuri Astrakhan <[email protected]>
What a messy PR.. Sorry about this.. Next time no PRs at 3:30AM.. |
I got insomnia either last night.. loll |
Co-authored-by: Lucas <[email protected]>
nyurik
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
could not go to sleep, so PR instead.. insomnia is a bitch ^^
This adds a version warning for postgis<3.5
Yes, it might be a bit too early too tell, but all signs point to older versions being buggy.
Lets keep #1651 open to keep tabs on weather the upstream issue changes.