Fix marker popup console error #213
Merged
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShellyDCMS
reviewed
Nov 7, 2024
Comment on lines
+9
to
+20
| jasmine.createSpyObj( | ||
| [ | ||
| 'addMarker', | ||
| 'removeMarker', | ||
| 'removePopupFromMap', | ||
| 'createPopup', | ||
| 'addPopupToMarker' | ||
| ], | ||
| { | ||
| mapCreated$: of(true), | ||
| } | ||
| ); |
There was a problem hiding this comment.
just wondering, can you use ts-stubber with jasmine.createSpy?
There was a problem hiding this comment.
What would be the benefit in this case? The downside is obviously another dependency to maintain...
ShellyDCMS
reviewed
Nov 7, 2024
marcjulian
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211 as this issue had two bug associated with it.
This is done by removing the popup using the map service (mainly unregistering the events) even in the case where marker was already destroyed.