Fixed adding extra child just detach (#14)

<!--

Thank you for submitting a pull request!

Here's a checklist you might find useful.
[ ] There is an associated issue that is labelled
  'Bug' or 'help wanted' or is in the Community milestone
[ ] Code is up-to-date with the `main` branch
[ ] You've successfully run `npm test` locally
[ ] There are new or updated tests validating the change

-->

Fixes #

src/controls/MMapGeolocationControl/index.ts

@@ -131,6 +131,8 @@ class MMapGeolocationControl extends mappable.MMapGroupEntity<MMapGeolocationCon
     }
 
     protected override _onDetach() {
+        this._control.removeChild(this._button);
+        this.removeChild(this._control);
         this._unwatchThemeContext?.();
     }
 

src/controls/MMapRotateControl/index.ts

@@ -32,14 +32,11 @@ type DefaultProps = typeof defaultProps;
 export class MMapRotateControl extends mappable.MMapComplexEntity<MMapRotateControlProps, DefaultProps> {
     static defaultProps = defaultProps;
     static [mappable.optionsKeyVuefy] = MMapRotateControlVuefyOptions;
-    private _control!: MMapControl;
-    private _rotateControl!: InternalRotateControl;
+    private _control: MMapControl;
+    private _rotateControl: InternalRotateControl;
 
     constructor(props: MMapRotateControlProps) {
         super(props);
-    }
-
-    protected _onAttach(): void {
         this._control = new mappable.MMapControl({transparent: true});
         this._rotateControl = new InternalRotateControl(this._props);
 
@@ -64,12 +61,15 @@ export class InternalRotateControl extends mappable.MMapComplexEntity<MMapRotate
     private _startMovePosition?: Position;
     private _startAzimuth?: number;
 
-    protected _onAttach(): void {
+    constructor(props: MMapRotateControlProps) {
+        super(props);
         this._listener = new mappable.MMapListener({
             onUpdate: (event) => this._onMapUpdate(event.camera)
         });
         this.addChild(this._listener);
+    }
 
+    protected _onAttach(): void {
         this._element = document.createElement('mappable');
         this._element.textContent = 'N';
         this._element.classList.add(ROTATE_CONTROL_CLASS);

src/controls/MMapRotateTiltControl/MMapRotateControl.ts

@@ -22,14 +22,13 @@ export class MMapRotateControl extends mappable.MMapGroupEntity<MMapRotateTiltCo
 
     constructor(props: MMapRotateTiltControlProps) {
         super(props);
-    }
-
-    protected _onAttach(): void {
         this._listener = new mappable.MMapListener({
             onUpdate: (event) => this._onMapUpdate(event.camera)
         });
         this.addChild(this._listener);
+    }
 
+    protected _onAttach(): void {
         this._element = document.createElement('mappable');
         this._element.classList.add(ROTATE_CONTROL_CLASS);
 

src/controls/MMapRotateTiltControl/MMapTiltControl.ts

@@ -19,14 +19,13 @@ export class MMapTiltControl extends mappable.MMapComplexEntity<MMapRotateTiltCo
 
     constructor(props: MMapRotateTiltControlProps) {
         super(props);
-    }
-
-    protected _onAttach(): void {
         this._listener = new mappable.MMapListener({
             onUpdate: (event) => this._onMapUpdate(event.camera)
         });
         this.addChild(this._listener);
+    }
 
+    protected _onAttach(): void {
         this._element = document.createElement('mappable');
         this._element.classList.add(TILT_CONTROL_CLASS);
         const {tilt, tiltRange} = this.root;

src/controls/MMapRotateTiltControl/index.ts

@@ -37,9 +37,6 @@ export class MMapRotateTiltControl extends mappable.MMapComplexEntity<MMapRotate
 
     constructor(props: MMapRotateTiltControlProps) {
         super(props);
-    }
-
-    protected _onAttach(): void {
         this._control = new mappable.MMapControl({transparent: true});
         this._rotateControl = new MMapRotateControl(this._props);
         this._tiltControl = new MMapTiltControl(this._props);
@@ -48,6 +45,7 @@ export class MMapRotateTiltControl extends mappable.MMapComplexEntity<MMapRotate
         this._control.addChild(this._rotateControl);
         this.addChild(this._control);
     }
+
     protected _onUpdate(): void {
         this._rotateControl.update(this._props);
         this._tiltControl.update(this._props);

src/controls/MMapSearchControl/index.ts

@@ -252,6 +252,7 @@ class MMapSearchControl extends mappable.MMapComplexEntity<MMapSearchControlProp
     }
 
     protected override _onDetach(): void {
+        this._control.removeChild(this._search);
         this.removeChild(this._control);
     }
 }

src/controls/MMapTiltControl/index.ts

@@ -37,9 +37,6 @@ export class MMapTiltControl extends mappable.MMapComplexEntity<MMapTiltControlP
 
     constructor(props: MMapTiltControlProps) {
         super(props);
-    }
-
-    protected _onAttach(): void {
         this._control = new mappable.MMapControl({transparent: true});
         this._tiltControl = new InternalTiltControl(this._props);
 

src/markers/MMapDefaultMarker/index.ts

@@ -196,6 +196,13 @@ export class MMapDefaultMarker extends mappable.MMapComplexEntity<MMapDefaultMar
         this._marker.update({...this._props, onClick: this._onMarkerClick});
     }
 
+    protected override _onDetach(): void {
+        if (this._popup) {
+            this.removeChild(this._popup);
+        }
+        this.removeChild(this._marker);
+    }
+
     private _createPopupMarker() {
         return new MMapPopupMarker({
             ...this._props,

src/markers/MMapPopupMarker/index.ts

@@ -138,6 +138,10 @@ export class MMapPopupMarker extends mappable.MMapComplexEntity<MMapPopupMarkerP
         this._marker.update(this._props);
     }
 
+    protected _onDetach(): void {
+        this.removeChild(this._marker);
+    }
+
     private _updateTheme() {
         const themeCtx = this._consumeContext(mappable.ThemeContext);
         const {theme} = themeCtx;