Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
matthew44-mappable committed Apr 19, 2024
1 parent b496fb8 commit d7ed271
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/markers/MMapDefaultMarker/index.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@keyframes hint-hover {
@keyframes mappable--default-marker-hint-hover {
from {
margin-left: -10px;
opacity: 0;
Expand Down Expand Up @@ -37,7 +37,7 @@
}
.mappable--default-marker-point:hover .mappable--hint__hovered {
display: inline-flex;
animation: hint-hover 200ms ease-out;
animation: mappable--default-marker-hint-hover 200ms ease-out;
}
.mappable--hint-title {
display: block;
Expand Down
8 changes: 1 addition & 7 deletions src/markers/MMapDefaultMarker/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ export class MMapDefaultMarker extends mappable.MMapComplexEntity<MMapDefaultMar
private _titleHint: HTMLElement;
private _subtitleHint: HTMLElement;

private _unwatchThemeContext?: () => void;

constructor(props: MMapDefaultMarkerProps) {
super(props);
}
Expand Down Expand Up @@ -120,7 +118,7 @@ export class MMapDefaultMarker extends mappable.MMapComplexEntity<MMapDefaultMar
this._marker = new mappable.MMapMarker(this._props, this._markerElement);
this.addChild(this._marker);

this._unwatchThemeContext = this._watchContext(mappable.ThemeContext, () => this._updateTheme(), {
this._watchContext(mappable.ThemeContext, () => this._updateTheme(), {
immediate: true
});
}
Expand Down Expand Up @@ -153,10 +151,6 @@ export class MMapDefaultMarker extends mappable.MMapComplexEntity<MMapDefaultMar
this._marker.update(this._props);
}

protected _onDetach(): void {
this._unwatchThemeContext?.();
}

private _createHintContainer(): HTMLElement {
const {title, subtitle, staticHint} = this._props;
const hintContainer = document.createElement('mappable');
Expand Down
2 changes: 1 addition & 1 deletion tools/icons/fetch-icons.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const REGION_CODE_REGEXP = /_([a-z]{2})_/;
export const SIZE_REGEXP = /_([0-9]{2})/;
/** RegExp to discard rubrics fallbacks */
const RUBRIC_FALLBACK_REGEXP = /fallback_.+\d{2}$/;
const INTL_REGION_CODES = new Intl.DisplayNames(['en', 'ru'], {type: 'region'});
const INTL_REGION_CODES = new Intl.DisplayNames(['en'], {type: 'region'});
/** A number between 0.01 and 4, the image scaling factor */
const IMAGE_SCALE = 1;
const ICONS_PER_CHUNK = 100;
Expand Down

0 comments on commit d7ed271

Please sign in to comment.