Add control of rotation and tilt to the map #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew44-mappable
force-pushed
the
rotate-tilt-control
branch
from
82e6681 to
9439d9a
Compare
matthew44-mappable
requested review from
xdan and
shtyr-maxim
and removed request for
xdan and
shtyr-maxim
src/controls/utils/angle-utils.ts
Outdated
|
|
||
| export const DEG_TO_RAD = Math.PI / 180; | ||
| export const RAD_TO_DEG = 180 / Math.PI; | ||
| export const MIN_TILT_DEG = 0; |
There was a problem hiding this comment.
Those must be taken from MMap.
| import {MMapCameraRequest} from '@mappable-world/mappable-types/imperative/MMap'; | ||
| import type {MMapRotateTiltControlProps} from '.'; | ||
| import { | ||
| CLICK_TOLERANCE_PX, |
There was a problem hiding this comment.
Why is CLICK_TOLERANCE_PX in angle-utils?
There was a problem hiding this comment.
Because CLICK_TOLERANCE_PX is needed in both tilt controls (MMapTiltControl and MMapRotateTiltControl). I have not found another place where I can declare this variable and export it to both controls.
matthew44-mappable
force-pushed
the
rotate-tilt-control
branch
from
8f0d0a6 to
cf599ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add controls: