Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding default markers and icon presets for them #2

Merged
merged 43 commits into from
Apr 27, 2024
Merged

Adding default markers and icon presets for them #2

merged 43 commits into from
Apr 27, 2024

Conversation

matthew44-mappable
Copy link
Contributor

@matthew44-mappable matthew44-mappable commented Mar 19, 2024 •
edited
Loading

Added default markers in package:

  • Markers have a preset of icons and colors
  • Markers can have hints
  • Markers can have 3 sizes: normal pin, small marker and micro marker
  • Supports light and dark theme

To get a set of icons and colors, a script is created that gets them from Figma. In ENV, you need to specify the variables FIGMA_API_TOKEN and FIGMA_FILE_ID.

@matthew44-mappable matthew44-mappable requested a review from xdan March 28, 2024 18:52
@matthew44-mappable matthew44-mappable force-pushed the default-markers branch 4 times, most recently from eb8057d to 50259c1 Compare April 4, 2024 08:48
@matthew44-mappable matthew44-mappable force-pushed the default-markers branch 2 times, most recently from fc0de04 to 1d32477 Compare April 10, 2024 15:16
@flapenguin-mappable
Copy link

What about popups?

@matthew44-mappable
Copy link
Contributor Author

What about popups?

In this pull request, I have decided to collect only default markers without popups. I plan to add popups together with tooltips in a future PR, as the logic for their operation is similar.

flapenguin-mappable
flapenguin-mappable reviewed Apr 16, 2024
View reviewed changes
Copy link

@flapenguin-mappable flapenguin-mappable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great. But don't use __impl... and prefix css stuff properly.

src/icons/icons.ts Outdated Show resolved Hide resolved
src/markers/MMapDefaultMarker/index.css Outdated Show resolved Hide resolved
src/markers/MMapDefaultMarker/index.ts Outdated Show resolved Hide resolved
tools/utils/make-chunks.ts Outdated Show resolved Hide resolved
src/markers/MMapDefaultMarker/index.ts Outdated Show resolved Hide resolved
src/markers/MMapDefaultMarker/index.ts Show resolved Hide resolved
src/markers/MMapDefaultMarker/index.ts Show resolved Hide resolved
src/internal/internal.d.ts Show resolved Hide resolved
@matthew44-mappable matthew44-mappable merged commit 908fc46 into main Apr 27, 2024
1 check passed
@matthew44-mappable matthew44-mappable deleted the default-markers branch April 27, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flapenguin-mappable flapenguin-mappable flapenguin-mappable approved these changes

@xdan xdan Awaiting requested review from xdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew44-mappable @flapenguin-mappable