Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controls #28

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Fix controls #28

merged 5 commits into from
Aug 2, 2024

Conversation

matthew44-mappable
Copy link
Contributor

Fixes #

In the search control:

  • add a props for placeholder

In the route building control:

  • remove the route information bar when clearing the route
  • autofocus on the second route point when selecting the first one
  • updating the placeholder of the props

shmaxim-mappable
shmaxim-mappable approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@shmaxim-mappable shmaxim-mappable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/controls/MMapRouteControl/helpers.ts Outdated Show resolved Hide resolved
@matthew44-mappable matthew44-mappable merged commit 5966513 into main Aug 2, 2024
1 check passed
@matthew44-mappable matthew44-mappable deleted the fix-controls branch August 2, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmaxim-mappable shmaxim-mappable shmaxim-mappable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew44-mappable @shmaxim-mappable