Add tooltip and popup markers #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I made it a separate entity that can be added to the map or made part of some kind of marker. Tooltip, Balloon, Popup are all components from the same category, but have different purposes:
Regarding naming, suggestions are accepted) |
matthew44-mappable
force-pushed
the
add-popup-tooltip
branch
3 times, most recently
from
ab6fef6 to
8aeb780
Compare
matthew44-mappable
force-pushed
the
add-popup-tooltip
branch
from
8aeb780 to
c96c272
Compare
xdan
reviewed
May 7, 2024
shmaxim-mappable
approved these changes
May 8, 2024
matthew44-mappable
added a commit
that referenced
this pull request
May 28, 2024
* Added getting information about icons from Figma * Added getting links to icons * restructuring inside the tools folder * Fetching components only with export settings * load icon in local folder * uploading icons from Figma to a local folder * export only svg files * refactor * optimize svg and filter fallback icons * generate types for icons * generate icons list in md file * filter fill-opacity icons * default marker * add nanospinner in cli tool * path as common constants, nanospinner error in catch * show pin with icon * fetch colors from Figma * color props * optional props * custom color * add fallback icon * size props in marker * Downscale if no small icon * upgrade markers * download icons * fix * took chunk function from lodash * rename generated files * add tooltip marker * tooltip combined positions, tooltip offset * support dark theme * separated tooltip and balloon * add default popup * remove close callback from popup content * remove mock MMapPopupMarker * add overrides * popups examples * add unit-tests * add prefix in css * add open animations * remove __impl * add popup in default marker * fix popup in marker * Rename ballon to popup * Rename tooltip to text-popup * fix issues * remove text popup and default popup * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new components:
MMapPopupMarkeris a popup with custom content. It may have a different position relative to the object that the tail points to.Updates:
MMapDefaultMarkermay contain a popup. You can specify the parameters of the popup window using thepopupprop.