Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added absent team and follow subscriptions to subscription options #1064

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

AndrewPhilbin
Copy link
Contributor

Team and Follow options are included in UI settings but were not present in subscription upsert function, making the settings non-functional. Added to upsert function.

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ljdelight ljdelight self-requested a review September 4, 2023 19:51
Copy link
Contributor

@ljdelight ljdelight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch on the missed update, and I checked for any other missing fields and didn't see any.

@AndrewPhilbin AndrewPhilbin merged commit 2a2a335 into dev Sep 5, 2023
4 checks passed
@AndrewPhilbin AndrewPhilbin deleted the AndrewPhilbin/fixNotificationSettings branch September 5, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants