Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resetTaskBundle endpoint #1107

Merged
merged 26 commits into from
May 12, 2024
Merged

Conversation

CollinBeczak
Copy link
Contributor

@CollinBeczak CollinBeczak commented Mar 2, 2024

Frontend: maproulette/maproulette3#2291

Changes:

This was implemented to lock all tasks in the bundle in certain contexts. For example, when a user goes to review a bundle, lockedTasks will be set to true so that all the tasks in the bundle the reviewer is reviewing will be locked.

Old route to to fetch a task bundle
GET /taskBundle/:id
New route
GET /taskBundle/:id?lockedTasks=boolean

This new route was implemented to reset bundles if a user redirects away from the bundle after making changes and no submission. From a backend percpective, this endpoint sets the bundle to include only the provided taskIds in the taskIds param, and set those tasks status and review status to that of the primary task.
New route
POST /taskBundle/:id/reset?primaryId=Long&taskIds=List[Long])

@CollinBeczak CollinBeczak marked this pull request as ready for review March 12, 2024 23:00
@CollinBeczak CollinBeczak marked this pull request as draft April 22, 2024 00:44
@CollinBeczak CollinBeczak marked this pull request as ready for review April 26, 2024 18:21
@CollinBeczak CollinBeczak force-pushed the add-bundling-revert-to-endpoint branch from 33ab372 to 2719505 Compare May 12, 2024 02:08
Copy link

sonarcloud bot commented May 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@CollinBeczak CollinBeczak merged commit 2e643df into main May 12, 2024
6 of 7 checks passed
@CollinBeczak CollinBeczak deleted the add-bundling-revert-to-endpoint branch May 12, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant