Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to Play 2.9 #1118

Closed
wants to merge 1 commit into from
Closed

[WIP] Update to Play 2.9 #1118

wants to merge 1 commit into from

Conversation

ljdelight
Copy link
Contributor

Update sbt, plugins, and other dependencies to support running with Play 2.9 because Play 2.8 is out of support at the end of May 2024.

See here for more information https://www.playframework.com/documentation/2.9.x/Highlights29.

Specifically the updates are:

  • build.properties sbt version is updated from 1.7.2 to 1.9.9
  • project/plugins.sbt Play sbt plugin is updated from 2.8.21 to 2.9.3.
  • build.sbt supporting dependencies
    • sangria-play-json: 2.0.1 -> 2.0.2
    • sangria: 2.0.1 -> 4.0.2
    • play-json-joda: 2.8.2 -> 2.10.5
    • play-json: 2.8.2 -> 2.10.5
    • joda-time: 2.12.0 -> 2.12.7

@ljdelight
Copy link
Contributor Author

This failed in staging from the below graphql error. It works fine locally on mac/aarch64. More testing is needed...

Oops, cannot start the server.
com.google.inject.CreationException: Unable to create injector, see the following errors:

1) [Guice/ErrorInjectingConstructor]: NoSuchMethodError: 'scala.Some JsBoolean$.unapply(JsBoolean)'
  at GraphQL.<init>(GraphQL.scala:17)
  at GraphQLController.<init>(GraphQLController.scala:33)
      \_ for 1st parameter graphQL

@ljdelight ljdelight changed the title Update to Play 2.9 [WIP] Update to Play 2.9 May 20, 2024
@ljdelight ljdelight marked this pull request as draft May 20, 2024 19:41
Update sbt, plugins, and other dependencies to support running with Play 2.9
because Play 2.8 is out of support at the end of May 2024.

Folks that run MapRoulette locally or in some environment will need to update the APPLICATION_SECRET if it's not at lease 32 bytes.
This is detailed in issue <#1117> and also <https://www.playframework.com/documentation/3.0.x/ApplicationSecret>

For more information about Play 2.9, see here <https://www.playframework.com/documentation/2.9.x/Highlights29>.

Specifically the updates are:

- `build.properties` sbt version is updated from `1.7.2` to `1.9.9`
- `project/plugins.sbt` Play sbt plugin is updated from `2.8.21` to `2.9.3`.
- `build.sbt` supporting dependencies
  - `sangria-play-json` 2.0.1 -> `sangria-play-json-play29` 2.0.3
  - `sangria`: 2.0.1 -> 4.0.2
  - `play-json-joda`: 2.8.2 -> 2.10.5
  - `play-json`: 2.8.2 -> 2.10.5
  - `play-mailer`: 8.0.1 -> 9.0.0
  - `play-mailer-guice`: 8.0.1 -> 9.0.0
  - `joda-time`: 2.12.0 -> 2.12.7
@ljdelight ljdelight force-pushed the ljdelight/updatePlay branch from 30132b2 to 8029342 Compare May 25, 2024 19:47
Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ljdelight
Copy link
Contributor Author

I resolved the issue. I'll close this PR and make a new one so I don't have to copy the updated description

@ljdelight ljdelight closed this May 25, 2024
@ljdelight ljdelight deleted the ljdelight/updatePlay branch May 25, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant