fix changeset submission bug for tag fix tasks with relations #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ljdelight
approved these changes
May 26, 2024
There was a problem hiding this comment.
@CollinBeczak this looks good to me, great discovery on the cause!
My only suggestion is to configure JOSM and MapRoulette (running locally) to use the dev OSM site. Pushing changesets to the production database side isn't a good practice (eg change 7 for the relation https://www.openstreetmap.org/relation/272138/history/7).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved: maproulette/maproulette3#2344
In our changeset provider, we utilize a custom versioned object for constructing changesets for nodes, ways, and relations. However, the versioned object for relations previously employed a way wrapper, as illustrated below:
This resulted in OpenStreetMap searching for a way with the relation ID, leading to the error message:
https://www.openstreetmap.org/api/0.6/changeset/{changesetId}/upload failed with status code 412 (Precondition failed: Way {wayId} must have at least one node)Relations necessitate a structure like so:
This pull request addresses this issue by implementing the required change.