Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more information in notification settings #2101

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

AndrewPhilbin
Copy link
Contributor

Addresses #2005. Changed layout of Notification Settings and added tooltips to each setting header.

Screen Shot 2023-09-12 at 1 30 44 PM

@codecov-commenter
Copy link

Codecov Report

Merging #2101 (c565583) into develop (67a08ef) will increase coverage by 0.00%.
Report is 19 commits behind head on develop.
The diff coverage is 25.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff            @@
##           develop    #2101   +/-   ##
========================================
  Coverage    24.96%   24.97%           
========================================
  Files          638      638           
  Lines        21587    21589    +2     
  Branches      6567     6568    +1     
========================================
+ Hits          5389     5391    +2     
  Misses       13574    13574           
  Partials      2624     2624           
Files Changed Coverage Δ
...Profile/UserSettings/NotificationSettingsSchema.js 13.79% <0.00%> (-1.60%) ⬇️
src/pages/Profile/UserSettings/UserSettings.js 0.00% <0.00%> (ø)
...ustom/RJSFFormFieldAdapter/RJSFFormFieldAdapter.js 41.17% <60.00%> (+0.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AndrewPhilbin AndrewPhilbin marked this pull request as draft September 12, 2023 21:58
@AndrewPhilbin AndrewPhilbin marked this pull request as ready for review September 12, 2023 22:25
@AndrewPhilbin AndrewPhilbin merged commit f2c3687 into develop Sep 12, 2023
2 checks passed
@jschwarz2030 jschwarz2030 deleted the NotificationSettingOverhaul branch October 18, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants