-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add global toggle to find challenge page #2382
Open
CollinBeczak
wants to merge
5
commits into
main
Choose a base branch
from
add-global-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollinBeczak
changed the title
add global toggle to find challenge page and include the show archive…
add global toggle to find challenge page and include the show archived filter in the challenge result list
Jul 15, 2024
CollinBeczak
changed the title
add global toggle to find challenge page and include the show archived filter in the challenge result list
add global toggle to find challenge page
Aug 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2382 +/- ##
==========================================
- Coverage 23.48% 23.47% -0.01%
==========================================
Files 649 650 +1
Lines 22503 22515 +12
Branches 6927 6930 +3
==========================================
+ Hits 5285 5286 +1
- Misses 14405 14413 +8
- Partials 2813 2816 +3 ☔ View full report in Codecov by Sentry. |
…d filter in the challenge result list
CollinBeczak
force-pushed
the
add-global-filter
branch
from
November 15, 2024 19:16
3b79c07
to
8eee166
Compare
jake-low
reviewed
Dec 2, 2024
jake-low
reviewed
Dec 10, 2024
jake-low
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend: maproulette/maproulette-backend#1136
Resolves: #2373 & #2350
This PR introduces a new "Show Global" filter on the find challenges page. When unchecked, this filter excludes all challenges not classified as global. The global classification is determined by backend conditions, currently defined as challenges whose tasks span over 180 degrees horizontally or 90 degrees vertically on the map.