Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global toggle to find challenge page #2382

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Jul 15, 2024

Backend: maproulette/maproulette-backend#1136

Resolves: #2373 & #2350

Screenshot 2024-07-15 at 1 52 54 PM

This PR introduces a new "Show Global" filter on the find challenges page. When unchecked, this filter excludes all challenges not classified as global. The global classification is determined by backend conditions, currently defined as challenges whose tasks span over 180 degrees horizontally or 90 degrees vertically on the map.

@CollinBeczak CollinBeczak changed the title add global toggle to find challenge page and include the show archive… add global toggle to find challenge page and include the show archived filter in the challenge result list Jul 15, 2024
@CollinBeczak CollinBeczak marked this pull request as ready for review July 19, 2024 22:10
@CollinBeczak CollinBeczak changed the title add global toggle to find challenge page and include the show archived filter in the challenge result list add global toggle to find challenge page Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 23.47%. Comparing base (ecfbb75) to head (3b79c07).
Report is 12 commits behind head on main.

Files Patch % Lines
...vices/Challenge/ChallengeGlobal/ChallengeGlobal.js 25.00% 2 Missing and 1 partial ⚠️
src/components/ChallengePane/ChallengePane.js 60.00% 2 Missing ⚠️
...components/HOCs/WithSearchRoute/WithSearchRoute.js 0.00% 2 Missing ⚠️
src/services/Challenge/Challenge.js 0.00% 1 Missing and 1 partial ⚠️
src/services/Search/Search.js 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
- Coverage   23.48%   23.47%   -0.01%     
==========================================
  Files         649      650       +1     
  Lines       22503    22515      +12     
  Branches     6927     6930       +3     
==========================================
+ Hits         5285     5286       +1     
- Misses      14405    14413       +8     
- Partials     2813     2816       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak marked this pull request as draft November 15, 2024 19:12
@CollinBeczak CollinBeczak marked this pull request as ready for review November 15, 2024 21:20
@CollinBeczak CollinBeczak requested a review from jake-low December 9, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "global challenge" Boolean filter to Challenge discovery
2 participants