Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved linting issues in JavaScript files #51

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

epraneeth98
Copy link
Contributor

@epraneeth98 epraneeth98 commented Jun 20, 2019

PR checklist Status
Is code analysis task executed and issues resolved in the Java/Kotlin code? No
Is code analysis task executed and issues resolved in the CPP/native code? Yes
Is the version code set in the AndroidManifest.xml or build.gradle file to 1 more than the version which has already been published? NA
Is code commenting done properly for the changes made? Yes
Is correct variable naming convention followed? Yes
Is auto formatting shortcut Ctrl+Alt+Shift+L executed in all files? Yes
Are the message strings used in the application taken from strings.xml file? NA
Are the permissions which are not required removed from AndroidManifest.java file? NA
Is the uses-feature tag used for only must have feature in AndroidManifest.java file? NA
Are the generated files correctly configured in .gitignore? NA
Are the release signing configurations removed from the gradle files? NA
Is commented code removed from all files? Yes
Are updated images compressed (< 100 KB)? NA
Typos in any string. For example: Variable/method names, hardcoded strings, commit messages, PR titles, issues, code comments? No

This PR addresses issue #41

@epraneeth98 epraneeth98 requested a review from Shailin June 20, 2019 13:01
@epraneeth98 epraneeth98 self-assigned this Jun 20, 2019
@epraneeth98 epraneeth98 added the enhancement New feature or request label Jun 20, 2019
@epraneeth98 epraneeth98 changed the title Resolved linting issues in .js files Resolved linting issues in Java Script files Jun 20, 2019
@epraneeth98 epraneeth98 requested a review from mathewnik90 June 20, 2019 13:11
@epraneeth98 epraneeth98 changed the title Resolved linting issues in Java Script files Resolved linting issues in JavaScript files Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant