Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use retain_all when fetching graph #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HalFrgrd
Copy link

@HalFrgrd HalFrgrd commented Jul 6, 2024

retain_all : bool
        if True, return the entire graph even if it is not connected.
        otherwise, retain only the largest weakly connected component.

If the streets aren't all connected, some streets are not fetched. Turning retain_all on ensures all streets in the area are drawn.

@Guillaume-Fgt
Copy link

After two days scratching my head to find why some highway=raceway weren't showing, I found your PR. After checking, this was the two racetracks that weren't connected to any service road. Thank you. I solved it by editing the map in my case. It should at least be added to the Readme if this PR is not accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants