-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1867456 [wpt PR 43443] - Reland "[soft-navigations] move startTim…
…e to processing end", a=testonly Automatic update from web-platform-tests Reland "[soft-navigations] move startTime to processing end" This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9 It better takes into account event bubbling, and the fact we see multiple tasks in a single EventScope in those cases. It also tests this case specifically. Original change's description: > [soft-navigations] move startTime to processing end > > This CL aligns the implementation with [1], and sets the soft navigation > start time to be the processingEnd of the relevant earlier event. > > It also cleans up a few bits of code that became useless, as well as > issues around PerInteractionData copying that were buggy yet hidden > before the timing of setting the different attributes was changed. > > > [1] WICG/soft-navigations#14 > > Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5 > Bug: 1505059 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108 > Reviewed-by: Ian Clelland <iclellandchromium.org> > Commit-Queue: Yoav Weiss <yoavweisschromium.org> > Cr-Commit-Position: refs/heads/main{#1230490} Bug: 1505059 Change-Id: I8c3664588c937e91643651d86d5a9635433e8e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713 Commit-Queue: Yoav Weiss <yoavweisschromium.org> Reviewed-by: Ian Clelland <iclellandchromium.org> Cr-Commit-Position: refs/heads/main{#1231299} -- wpt-commits: 0b3dc935fcac323b0398b24b314e489aec49fb9d wpt-pr: 43443 UltraBlame original commit: c6a6af6e5971373dca98aa050b273c6eebd55dce
- Loading branch information
Showing
11 changed files
with
415 additions
and
120 deletions.
There are no files selected for viewing
243 changes: 243 additions & 0 deletions
243
testing/web-platform/tests/soft-navigation-heuristics/click-event-bubbles.tentative.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,243 @@ | ||
< | ||
! | ||
DOCTYPE | ||
HTML | ||
> | ||
< | ||
html | ||
> | ||
< | ||
head | ||
> | ||
< | ||
meta | ||
charset | ||
= | ||
" | ||
utf | ||
- | ||
8 | ||
" | ||
> | ||
< | ||
script | ||
src | ||
= | ||
" | ||
/ | ||
resources | ||
/ | ||
testharness | ||
. | ||
js | ||
" | ||
> | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
script | ||
src | ||
= | ||
" | ||
/ | ||
resources | ||
/ | ||
testharnessreport | ||
. | ||
js | ||
" | ||
> | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
script | ||
src | ||
= | ||
" | ||
/ | ||
resources | ||
/ | ||
testdriver | ||
. | ||
js | ||
" | ||
> | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
script | ||
src | ||
= | ||
" | ||
/ | ||
resources | ||
/ | ||
testdriver | ||
- | ||
vendor | ||
. | ||
js | ||
" | ||
> | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
script | ||
src | ||
= | ||
" | ||
resources | ||
/ | ||
soft | ||
- | ||
navigation | ||
- | ||
helper | ||
. | ||
js | ||
" | ||
> | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
/ | ||
head | ||
> | ||
< | ||
body | ||
> | ||
< | ||
main | ||
id | ||
= | ||
main | ||
> | ||
< | ||
a | ||
id | ||
= | ||
link | ||
> | ||
Click | ||
me | ||
! | ||
< | ||
/ | ||
a | ||
> | ||
< | ||
/ | ||
main | ||
> | ||
< | ||
script | ||
> | ||
const | ||
link | ||
= | ||
document | ||
. | ||
getElementById | ||
( | ||
" | ||
link | ||
" | ||
) | ||
; | ||
/ | ||
/ | ||
Adding | ||
a | ||
noop | ||
event | ||
that | ||
the | ||
" | ||
click | ||
" | ||
would | ||
bubble | ||
to | ||
. | ||
document | ||
. | ||
getElementById | ||
( | ||
" | ||
main | ||
" | ||
) | ||
. | ||
addEventListener | ||
( | ||
" | ||
click | ||
" | ||
( | ||
) | ||
= | ||
> | ||
{ | ||
} | ||
) | ||
; | ||
testSoftNavigation | ||
( | ||
{ | ||
addContent | ||
: | ||
( | ||
) | ||
= | ||
> | ||
{ | ||
addTextParagraphToMain | ||
( | ||
" | ||
Lorem | ||
Ipsum | ||
" | ||
) | ||
; | ||
} | ||
link | ||
: | ||
link | ||
test | ||
: | ||
" | ||
Ensure | ||
event | ||
bubbling | ||
works | ||
well | ||
with | ||
soft | ||
navigations | ||
. | ||
" | ||
} | ||
) | ||
; | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
/ | ||
body | ||
> | ||
< | ||
/ | ||
html | ||
> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -224,22 +224,6 @@ | |
= | ||
> | ||
{ | ||
timestamps | ||
[ | ||
counter | ||
] | ||
[ | ||
" | ||
eventStart | ||
" | ||
] | ||
= | ||
performance | ||
. | ||
now | ||
( | ||
) | ||
; | ||
addTextToDivOnMain | ||
( | ||
) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.