Skip to content

Commit

Permalink
Revert "Don't assume roots validated the identity, just in case they …
Browse files Browse the repository at this point in the history
…did not."

This reverts commit 39b97f9.
  • Loading branch information
adamierymenko authored and glimberg committed Sep 21, 2021
1 parent c8a58b4 commit 30d5d5a
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions node/IncomingPacket.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -511,10 +511,7 @@ bool IncomingPacket::_doOK(const RuntimeEnvironment *RR,void *tPtr,const SharedP
case Packet::VERB_WHOIS:
if (RR->topology->isUpstream(peer->identity())) {
const Identity id(*this,ZT_PROTO_VERB_WHOIS__OK__IDX_IDENTITY);
// Good idea to locally validate here even if roots are doing so. In a truly distributed
// system there should not be single points of failure for global trust assertions.
if (id.locallyValidate())
RR->sw->doAnythingWaitingForPeer(tPtr,RR->topology->addPeer(tPtr,SharedPtr<Peer>(new Peer(RR,RR->identity,id))));
RR->sw->doAnythingWaitingForPeer(tPtr,RR->topology->addPeer(tPtr,SharedPtr<Peer>(new Peer(RR,RR->identity,id))));
}
break;

Expand Down

0 comments on commit 30d5d5a

Please sign in to comment.