[pull] master from opnsense:master #1270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
AdSchellevis
force-pushed
the
master
branch
3 times, most recently
from
272532c to
43a1743
Compare
fichtner
force-pushed
the
master
branch
2 times, most recently
from
89d5c6b to
f5ae0c8
Compare
AdSchellevis
force-pushed
the
master
branch
2 times, most recently
from
709906d to
bc2ca23
Compare
AdSchellevis
force-pushed
the
master
branch
5 times, most recently
from
3d71277 to
20a8006
Compare
AdSchellevis
force-pushed
the
master
branch
6 times, most recently
from
78845fc to
8ba454a
Compare
AdSchellevis
force-pushed
the
master
branch
2 times, most recently
from
810ecdc to
897d3cc
Compare
…tination addresses. When selecting multiple source or targets, a cartesian product is created for all combinations (one defined rule turns into multiple actual rules). In order to make this possible, we needed to refactor the base rule parsing. our generic `reader()` multiplies rules, which it already did for interfaces and ipprotocol. When feeding lists to `pf(4)` a similar action would be performed. The `convertAddress()` method has been renamed to `legacyMoveAddressFields()` as it now only remaps field structures into flattened fields, without validating their contents. This is needed so we can split source/destinations without caring about their validity (yet), `mapAddressInfo()` is added next which contains the same logic as previously in `convertAddress()` but executed after splitting the fields. The "Automation" module is more or less a reference implementation to show how the backend handles these now, 22fd0bf8763e14a5e1e7694853af0893dae585b7 is required for this to work. All changes should be backwards compatible, but deliver a slightly different ruleset in some cases (when multiple entries are already used), e.g. the rule below would be split into two on our end now: https://github.com/opnsense/core/blob/397a3dcdcefae4f0f99e45c74a613aea70fafa44/src/etc/inc/filter.lib.inc#L231-L237 `pfctl -sr` already showed two before our change.
…s fields. o merge src+srcmask, dst+dstmask into a single field o remove current clunky input and re-use the same javascript hooks as in MVC o re-use OPNsense\Firewall\Api\FilterController to list available options
… the options match
Take our chances with SSH. It looks like using 'early' facility surfaced this problem that was not as trigger happy before. The administration page does the same. PR: https://forum.opnsense.org/index.php?topic=43995.0
…en called without sufficient imports (missing libraries in registered plugins). Scripts like https://github.com/opnsense/core/blob/master/src/etc/rc.expireaccounts will die horribly at the moment when there's actual work to be done (although this example should likely be rmeoved for 25.1 anyway)
…/app/library/OPNsense/Firewall/SNatRule.php on line 95
remove overhead in BaseListField by passing references to the data with a CallbackValidator.
…cations Also introduces better sorting with a separate priority value as well as a refactored frontend. Includes some fixes for missing translations as well. To test a banner such as "the system is booting": flock -n -o /var/run/booting cat
Since legacy pages each define 'page-content-main', including it in fbegin.inc is not an option anymore. Manually setting the background to match the current one also introduces issues for themese so instead inject it dynamically and let it inherit the background color
Fixes: #7895 - Introduces a generalized function to handle "search" and "edit" in url hashes. - Can handle changing a tab before firing a search and/or edit. --------- Co-authored-by: Stephan de Wit <[email protected]>
Add search button in sessions that opens a new tab with prepopulated tunnel name in ipsec log search field --------- Co-authored-by: Stephan de Wit <[email protected]>
main benefit is that there is no search delay for a phrase that is provided during initialization. This commit also syncs with opnsense/jquery-bootgrid#8
The check is for the subnet use, not the CARP source check in between. PR: https://forum.opnsense.org/index.php?topic=44634.0
…m is unreachable.
This commit wraps our xmlrpc functions via configd and wires them via an api controller. In the long run we should consider moving to RESTful interfaces, but for now we will keep and cleanup the xmlrpc code. configd action "system ha services_cached" caches the service list for a couple of seconds to improve searchability via our standard grid functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )