Skip to content

Commit

Permalink
Fixed sphinx-build check in Makefile (celery#4728)
Browse files Browse the repository at this point in the history
If sphinx-build is not installed, the Makefile returns the cryptic
'recipe commences before first target.  Stop.' when building the docs.
The cause is a tab resulting in a syntax error. This was a bug in the
Makefile generated by Sphinx, which has since been fixed:
sphinx-doc/sphinx#2521

I've applied the same fix, which is removing the 'user-friendly'
message. The resulting error message is 'sphinx-build: Command not
found', which ought to be clear enough.
  • Loading branch information
mgeens authored and auvipy committed May 11, 2018
1 parent a11b09f commit 4ed3f82
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions docs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ SPHINXBUILD = sphinx-build
PAPER =
BUILDDIR = _build

# User-friendly check for sphinx-build
ifeq ($(shell which $(SPHINXBUILD) >/dev/null 2>&1; echo $$?), 1)
$(error The '$(SPHINXBUILD)' command was not found. Make sure you have Sphinx installed, then set the SPHINXBUILD environment variable to point to the full path of the '$(SPHINXBUILD)' executable. Alternatively you can add the directory with the executable to your PATH. If you don\'t have Sphinx installed, grab it from http://sphinx-doc.org/)
endif

# Internal variables.
PAPEROPT_a4 = -D latex_paper_size=a4
PAPEROPT_letter = -D latex_paper_size=letter
Expand Down

0 comments on commit 4ed3f82

Please sign in to comment.